Skip to content

chore: update maintenance dependencies#150

Open
afc163 wants to merge 5 commits into
mainfrom
codex/update-maintenance-deps
Open

chore: update maintenance dependencies#150
afc163 wants to merge 5 commits into
mainfrom
codex/update-maintenance-deps

Conversation

@afc163

@afc163 afc163 commented Jun 29, 2026

Copy link
Copy Markdown
Member

Summary

  • Link the Ant Design ecosystem logo in README files to https://ant.design
  • Update React, React DOM, TypeScript, ESLint, Testing Library, @types/, @typescript-eslint/, lint-staged, and related lint dependencies
  • Add ESLint flat config compatibility for ESLint 9 and TypeScript ESLint 8
  • Use grouped Dependabot updates for npm and GitHub Actions

Test Plan

  • npm run lint
  • npm run tsc

@vercel

vercel Bot commented Jun 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
footer Ready Ready Preview, Comment Jun 30, 2026 11:24am

@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@afc163, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 46 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 708c28e4-e231-4252-856e-22f81d61627d

📥 Commits

Reviewing files that changed from the base of the PR and between de99fd0 and c273e62.

📒 Files selected for processing (8)
  • .github/dependabot.yml
  • README.md
  • README.zh-CN.md
  • eslint.config.mjs
  • global.d.ts
  • package.json
  • react-compat.d.ts
  • tsconfig.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/update-maintenance-deps

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@socket-security

socket-security Bot commented Jun 29, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​@​types/​react@​18.3.31 ⏵ 19.2.17100 +11007995100
Addednpm/​@​eslint/​eslintrc@​3.3.59910010084100
Addednpm/​@​eslint/​js@​9.39.410010010088100
Addednpm/​typescript@​6.0.3100100909690
Addednpm/​eslint@​9.39.49710010096100

View full report

@socket-security

socket-security Bot commented Jun 29, 2026

Copy link
Copy Markdown

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades the project to React 19, ESLint 9, and updates various dependencies, along with adding a new ESLint flat configuration and compatibility type definitions. Feedback on these changes highlights several type safety and configuration concerns: disabling strict mode and adding explicit false overrides in tsconfig.json degrades type safety; declaring Jest globals as any in global.d.ts overrides strongly-typed definitions; monkey-patching React types in react-compat.d.ts is fragile compared to updating the codebase for React 19 compatibility; and the runtime configuration normalization in eslint.config.mjs should be replaced with a direct migration to the flat config format.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread tsconfig.json
"lib": ["dom", "es2017"],
"jsx": "react",
"strict": true,
"strict": false,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Disabling strict mode degrades type safety across the entire codebase, making it easier for runtime errors (such as Cannot read properties of undefined) to slip through. It is highly recommended to keep strict: true and resolve any type issues directly, especially when upgrading to React 19 and TypeScript.

Suggested change
"strict": false,
"strict": true,

Comment thread tsconfig.json Outdated
Comment on lines +24 to +30
"ignoreDeprecations": "6.0",
"noImplicitAny": false,
"strictNullChecks": false,
"strictPropertyInitialization": false,
"strictFunctionTypes": false,
"noImplicitThis": false,
"strictBindCallApply": false

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

These explicit false overrides disable essential TypeScript compiler checks. If strict: true is maintained, these overrides are redundant and should be removed to ensure full type safety.

    "ignoreDeprecations": "6.0"

Comment thread global.d.ts Outdated
Comment on lines +58 to +67
declare const describe: any;
declare const it: any;
declare const test: any;
declare const beforeEach: any;
declare const afterEach: any;
declare const beforeAll: any;
declare const afterAll: any;
declare const expect: any;

declare module 'moment/locale/zh-cn';

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Declaring these Jest globals as any overrides the strongly-typed definitions provided by @types/jest (referenced on line 1). This disables type safety in your test files. Since @types/jest is already referenced, these declarations are redundant and should be removed.

Suggested change
declare const describe: any;
declare const it: any;
declare const test: any;
declare const beforeEach: any;
declare const afterEach: any;
declare const beforeAll: any;
declare const afterAll: any;
declare const expect: any;
declare module 'moment/locale/zh-cn';
declare module 'moment/locale/zh-cn';

Comment thread react-compat.d.ts
Comment on lines +3 to +14
declare module 'react' {
type ReactText = string | number;
function useRef<T = undefined>(): React.MutableRefObject<T | undefined>;
function isValidElement<P = any>(
object: {} | null | undefined,
): object is React.ReactElement<P>;
function cloneElement<P = any>(
element: React.ReactElement<P>,
props?: (Partial<P> & React.Attributes) | null,
...children: React.ReactNode[]
): React.ReactElement<P>;
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Monkey-patching the global react module to restore removed types (like ReactText) or override standard signatures (like useRef, isValidElement, cloneElement) is fragile and can cause type conflicts or mask actual type errors. It is highly recommended to update the codebase to be fully compatible with React 19 types (e.g., replacing ReactText with string | number directly) rather than using global overrides.

Comment thread eslint.config.mjs
Comment on lines +26 to +57
function normalizeConfig(config) {
const next = { ...config };

if (next.plugins?.['@typescript-eslint']) {
next.plugins = {
...next.plugins,
'@typescript-eslint': {
...next.plugins['@typescript-eslint'],
rules: {
...next.plugins['@typescript-eslint'].rules,
'ban-types': noopRule,
},
},
};
}

if (next.rules) {
next.rules = Object.fromEntries(
Object.entries(next.rules).filter(([ruleName]) => {
if (!ruleName.startsWith('@typescript-eslint/')) {
return true;
}
return (
recommendedTsRules.has(ruleName) ||
ruleName === '@typescript-eslint/ban-types'
);
}),
);
}

return next;
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The normalizeConfig function dynamically filters and overrides rules from the legacy .eslintrc.js to make it compatible with ESLint 9 and @typescript-eslint v8. This runtime patching is complex and fragile. It is highly recommended to fully migrate the configuration in .eslintrc.js to the new flat config format in eslint.config.mjs directly, which would eliminate the need for FlatCompat and this custom normalization logic.

@github-actions

github-actions Bot commented Jun 29, 2026

Copy link
Copy Markdown

❌ Deploy failed

PR preview ❌ Failed ❌ Failed
🔗 Preview https://react-component-footer-preview-pr-150.surge.sh (may be unavailable)
📝 Commitc273e62
🪵 LogsView logs
📋 Build log (last lines)
npm warn exec The following package was not found and will be installed: surge@0.27.4

   Running as afc163@gmail.com (Student)

        project: ./docs-dist
         domain: react-component-footer-preview-pr-150.surge.sh
           size: 38 files, 1.7 MB

   Aborted - you do not have permission to publish to react-component-footer-preview-pr-150.surge.sh

🤖 Powered by surge-preview

@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.77%. Comparing base (de99fd0) to head (c273e62).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #150   +/-   ##
=======================================
  Coverage   97.77%   97.77%           
=======================================
  Files           2        2           
  Lines          45       45           
  Branches       25       25           
=======================================
  Hits           44       44           
  Partials        1        1           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant